Skip to content

add guard to textureFrameAvailable #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Knightro63 merged 2 commits into from
Apr 22, 2026
+12 −2
Merged

add guard to textureFrameAvailable #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd6173
add guard to textureFrameAvailable
Apr 16, 2026
8e8a1ef
remove build
Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion flutter_angle/darwin/Classes/FlutterAnglePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,12 @@ import Flutter
result(FlutterError(code: "INVALID_ARGS", message: "Invalid texture ID", details: nil))
return
}
self.renders[textureId]!.textureFrameAvailable(result: result)
guard let render = self.renders[textureId] else {
// A late frame callback can arrive after the texture has been disposed.
result(nil)
return
}
render.textureFrameAvailable(result: result)
case "initOpenGL":
#if targetEnvironment(simulator)
eglInfo = nil
Expand Down
7 changes: 6 additions & 1 deletion ..._darwin/darwin/flutter_angle_darwin/Sources/flutter_angle_darwin/FlutterAnglePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ import Flutter
result(FlutterError(code: "INVALID_ARGS", message: "Invalid texture ID", details: nil))
return
}
self.renders[textureId]!.textureFrameAvailable(result: result)
guard let render = self.renders[textureId] else {
// A late frame callback can arrive after the texture has been disposed.
result(nil)
return
}
render.textureFrameAvailable(result: result)
case "initOpenGL":
#if targetEnvironment(simulator)
eglInfo = nil
Expand Down
Loading