Fix line and linesegments clone method. Similar to #113#129
Closed
vivagelive wants to merge 2 commits intoKnightro63:mainfrom
Closed
Fix line and linesegments clone method. Similar to #113#129vivagelive wants to merge 2 commits intoKnightro63:mainfrom
vivagelive wants to merge 2 commits intoKnightro63:mainfrom
Conversation
Owner
|
Hi @vivagelive, Thanks for finding some of these issues. I am going to be publishing removed_native_array_2 within the month. Could you make the changes there since this branch will be merged. Thank you |
Contributor
Author
|
Hi, @Knightro63, Have a nice day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I`ve done small fixes for clone/copy methods (Group, Line, LIneSegments).
Now Group clone() return Group type instead of Object3D and LineSegments clone() return LineSegments instead of Line.
This fixes similar to issue #113.
Have a nice day.