Retry file uploads final verify and expose value to UI#362
Open
Shivansps wants to merge 1 commit intoKnossosNET:mainfrom
Open
Retry file uploads final verify and expose value to UI#362Shivansps wants to merge 1 commit intoKnossosNET:mainfrom
Shivansps wants to merge 1 commit intoKnossosNET:mainfrom
Conversation
wookieejedi
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use maxFUploadRetries value to retry the final file verify once all file parts of a file are uploaded. I consider this as a bug as a fail or timeout fail here will abort the entire mod upload, and the retries are there to avoid this in case of network issues.
ALso make maxFUploadRetries configurable in the UI.