Quality fixes for for Piper when using larger models#347
Open
CashWilliams wants to merge 3 commits intoKoljaB:masterfrom
Open
Quality fixes for for Piper when using larger models#347CashWilliams wants to merge 3 commits intoKoljaB:masterfrom
CashWilliams wants to merge 3 commits intoKoljaB:masterfrom
Conversation
CashWilliams
force-pushed
the
quality
branch
from
d19ca2f to
1738f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds #244 / #346 to fix sound quality issues when using Piper with medium size models (at least). Without this, the output is choppy and sounds robotic. With this change the sound output sounds exactly like piper on the cli.
I know this is messy and don't expect it to be merged, but just providing as a starting point or guide for others if they notice this same issue.