Fix race condition on concurrent first invocations#144
Open
jalalawqati wants to merge 1 commit into
Open
Conversation
Owner
|
@jalalawqati Thanks for the fix, LGTM |
jalalawqati
force-pushed
the
invocations-thread-safety
branch
from
8849249 to
58c4dcd
Compare
Author
|
@Kolos65 Thanks for taking a look. I made a change and force-pushed the branch. Can you re-run the checks please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invocationswas a private lazy var. Swift lazy vars are not thread-safe, and if multiple threads access one before it's initialized, each creates its own instance and only the last one is kept. This caused verify to sometimes report 0 invocations for methods that were called, when those calls happened concurrently (e.g. viaasync let)The fix is to initialize
invocationseagerly in init(). Also changedreturns,actions,invocationsand invocationsSubject fromvartolet