Skip to content

Fix PAGESIZE to compile on systems where it's already defined as a macro. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
creationix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PAGESIZE to compile on systems where it's already defined as a macro. #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/simdjson_ffi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@

using namespace simdjson;


#ifndef PAGESIZE // This is defined as a macro on some systms.
// we will initialize it only once
static long PAGESIZE = 0;
#endif


// An optimization from https://github.com/simdjson/simdjson/blob/master/doc/performance.md#free-padding
Expand All @@ -16,9 +17,11 @@ static long PAGESIZE = 0;
// This is because reading within the boundary of a mapped memory page is guaranteed
// not to fail, even if these area might contain garbage data, simdjson will work correctly.
static bool need_allocation(const char *buf, size_t len) {
#ifndef PAGESIZE
if (PAGESIZE == 0) {
PAGESIZE = getpagesize();
}
#endif

SIMDJSON_DEVELOPMENT_ASSERT(PAGESIZE > 0);

Expand Down