Solved issue #5 sound effects#7
Solved issue #5 sound effects#7sanket95droid wants to merge 3 commits intoKonradLinkowski:masterfrom
Conversation
KonradLinkowski
left a comment
There was a problem hiding this comment.
Hi, thank you for your contribution :)
That's a pretty good job, but I would like you to fix the problems that I pointed out in the review
To make it more clear:
- make sure that no errors appear in the console
- remove old code in the comments
- changes to
package-lock.json,package.jsonandyarn.lockare redundant - we don't need two versions of each sound mp3 is enough
|
@KonradLinkowski did the requested changes except for the button please review it. |
|
@sanket95droid hey, please remove changes to |
|
@KonradLinkowski ok, should I also remove changes to |
|
@sanket95droid yes I fixed the issue you mentioned earlier about |
|
@KonradLinkowski please compare and merge my PR!! |
|
@sanket95droid I can't merge it because you didn't resolve the conflicts. |
|
Ohk i'll try to resolve those conflits and make a commit @KonradLinkowski |
@KonradLinkowski Done ✅ |
Used Three.js Audio section for adding audio :