chore(deps): bump tokio from 1.52.1 to 1.52.3#60
Conversation
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.52.1 to 1.52.3. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.52.1...tokio-1.52.3) --- updated-dependencies: - dependency-name: tokio dependency-version: 1.52.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
Skipping PR review because a bot author is detected. If you want to trigger CodeAnt AI, comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = "1.0" | ||
| tokio = { version = "1.39", features = ["rt-multi-thread", "macros", "fs"] } | ||
| tokio = { version = "1.52", features = ["rt-multi-thread", "macros", "fs"] } |
There was a problem hiding this comment.
SUGGESTION: Consider adding a comment explaining why tokio was updated to 1.52.3 instead of the latest version, if there's a specific reason.
| dependencies = [ | ||
| "libc", | ||
| "windows-sys 0.61.2", | ||
| "windows-sys 0.52.0", |
There was a problem hiding this comment.
WARNING: windows-sys version downgraded from 0.61.2 to 0.52.0. Please verify this is intentional and compatible with your codebase, as this is a significant version change in a system dependency.
| "libc", | ||
| "linux-raw-sys", | ||
| "windows-sys 0.61.2", | ||
| "windows-sys 0.52.0", |
There was a problem hiding this comment.
WARNING: windows-sys version downgraded from 0.61.2 to 0.52.0. Please verify this is intentional and compatible with your codebase.
| "security-framework-sys", | ||
| "webpki-root-certs", | ||
| "windows-sys 0.61.2", | ||
| "windows-sys 0.52.0", |
There was a problem hiding this comment.
WARNING: windows-sys version downgraded from 0.61.2 to 0.52.0. Please verify this is intentional and compatible with your codebase.
| "once_cell", | ||
| "rustix", | ||
| "windows-sys 0.61.2", | ||
| "windows-sys 0.52.0", |
There was a problem hiding this comment.
WARNING: windows-sys version downgraded from 0.61.2 to 0.52.0. Please verify this is intentional and compatible with your codebase.
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "b67dee974fe86fd92cc45b7a95fdd2f99a36a6d7b0d431a231178d3d670bbcc6" | ||
| checksum = "8fc7f01b389ac15039e4dc9531aa973a135d7a4135281b12d7c1bc79fd57fffe" | ||
| dependencies = [ |
There was a problem hiding this comment.
WARNING: windows-sys version downgraded from 0.61.2 to 0.52.0. Please verify this is intentional and compatible with your codebase.
| checksum = "c2a7b1c03c876122aa43f3020e6c3c3ee5c05081c9a00739faf7503aeba10d22" | ||
| dependencies = [ | ||
| "windows-sys 0.61.2", | ||
| "windows-sys 0.52.0", |
There was a problem hiding this comment.
WARNING: windows-sys version downgraded from 0.61.2 to 0.52.0. Please verify this is intentional and compatible with your codebase.
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (2 files)
This PR updates tokio from 1.52.1 to 1.52.3, which includes several sync-related fixes. The windows-sys version downgrades appear to be transitive dependencies pulled in by the tokio update. While dependency updates are generally good, the significant windows-sys version change (0.61.2 → 0.52.0) warrants verification that it doesn't break compatibility. Fix these issues in Kilo Cloud Reviewed by nemotron-3-super-120b-a12b-20230311:free · 585,144 tokens |
Bumps tokio from 1.52.1 to 1.52.3.
Release notes
Sourced from tokio's releases.
Commits
d875691chore: prepare Tokio v1.52.3 (#8130)e1aebb0Merge 'tokio-1.51.3' into 'tokio-1.52.x' (#8129)fd63094chore: prepare Tokio v1.51.3 (#8127)8c600d0Merge 'tokio-1.47.5' into 'tokio-1.51.x' (#8123)11bfc13chore: prepare Tokio v1.47.5 (#8122)f085b62sync: notify receivers in mpscOwnedPermit::release()method (#8075)30d25ccsync: require that anRwLockhasmax_readers != 0(#8076)9fccf53sync: returnEmptyfromtry_recv()when mpsc is closed with outstanding p...ebf61b4sync: fix underflow in mpsc channellen()(#8062)4abe9d7chore: prepare Tokio v1.52.2 (#8115)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)