Skip to content

Use expect_no_message() over expect_silent() #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavisVaughan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use expect_no_message() over expect_silent() #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Imports:
R.matlab
Suggests:
covr,
testthat,
testthat (>= 3.1.6),
knitr,
rmarkdown
License: GPL-3 | file LICENSE
Expand Down
10 changes: 5 additions & 5 deletions tests/testthat/test-load-data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test_that("test that it is possible to load multiple LANS summaries", {
load_LANS_summary (analysis = c("analysis1", "analysis2", "analysis3"),
base_dir = folder, load_zstacks = FALSE),
".*read successfully.*Z-stacks were not loaded")
expect_silent(
expect_no_message(
data <- load_LANS_summary (analysis = c("analysis1", "analysis2", "analysis3"),
base_dir = folder, load_zstacks = FALSE, quiet = TRUE))

Expand All @@ -40,7 +40,7 @@ test_that("test that it is possible to load multiple LANS summaries", {
load_LANS_summary (analysis = c("analysis1", "analysis2", "analysis3"),
base_dir = folder, load_zstacks = TRUE),
".*read successfully.*Z-stacks were loaded")
expect_silent(
expect_no_message(
data <- load_LANS_summary (analysis = c("analysis1", "analysis2", "analysis3"),
base_dir = folder, load_zstacks = TRUE, quiet = TRUE))

Expand All @@ -55,7 +55,7 @@ test_that("test that it is possible to load multiple LANS summaries", {
"17.38", "192.93", "0.83", "353", "2.45"))

# additional information
expect_silent(
expect_no_message(
data <- load_LANS_summary (analysis = c("analysis1", "analysis2", "analysis3"),
information = c("run1", "run2", "run3"),
date = as.Date(c("2015-01-01", "2016-02-25", "2017-03-04")),
Expand All @@ -78,8 +78,8 @@ test_that("test that it is possible to load LANS maps", {

expect_true(file.exists(folder <- system.file("extdata", "nanosims_data", package = "lans2r")))

expect_silent(maps <- load_LANS_maps (analysis = c("analysis1", "analysis2", "analysis3"),
base_dir = folder, quiet = TRUE))
expect_no_message(maps <- load_LANS_maps (analysis = c("analysis1", "analysis2", "analysis3"),
base_dir = folder, quiet = TRUE))

# check data
expect_equal(nrow(maps), as.integer(256^2 * 4 * 3))
Expand Down