Replace random_shuffle with std::shuffle for C++17#24
Open
OldCrow wants to merge 1 commit intoKorfLab:masterfrom
Open
Replace random_shuffle with std::shuffle for C++17#24OldCrow wants to merge 1 commit intoKorfLab:masterfrom
OldCrow wants to merge 1 commit intoKorfLab:masterfrom
Conversation
Use std::shuffle with a thread-local mt19937 engine in sequence::shuffle to preserve shuffle behavior with modern C++ standards. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::random_shufflecalls insequence::shuffle()withstd::shuffle<random>include and use a thread-localstd::mt19937enginesequence.hcomment to reflect the new APIWhy
std::random_shufflewas removed in C++17. This change restores compatibility with modern compilers while keeping sequence-shuffle behavior in one place.Co-Authored-By: Oz oz-agent@warp.dev