Task 10 — Add CI and release workflows for Beacon UPM package#9
Task 10 — Add CI and release workflows for Beacon UPM package#9KostasBan wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5db33c83b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }} | ||
| UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }} | ||
| UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }} |
There was a problem hiding this comment.
Guard Unity tests when PRs lack license secrets
This workflow runs on every pull_request, but the Unity step depends on UNITY_LICENSE, UNITY_EMAIL, and UNITY_PASSWORD from repository secrets; on fork-based PRs, GitHub does not expose those secrets, so game-ci/unity-test-runner will fail even when the change is valid. That makes external contributions consistently red unless maintainers intervene, so the Unity job should be conditionally skipped or switched to a non-secret path when those secrets are unavailable.
Useful? React with 👍 / 👎.
| ### Added | ||
| - TBD | ||
|
|
There was a problem hiding this comment.
Eliminate placeholder changelog text before tagging
In the prepare-release path, the new version section is auto-created with - TBD entries and the workflow immediately commits and tags, after which github-release reads that section to build the published release body. When maintainers run workflow_dispatch for a new version without pre-authoring notes, the released notes will include placeholders instead of actual changes; this should either fail fast on placeholder content or derive real notes from Unreleased before tagging.
Useful? React with 👍 / 👎.
Motivation
Description
.github/workflows/ci.ymlthat triggers on PRs tomain/developand pushes todevelop, runs Unity EditMode tests withgame-ci/unity-test-runner, uploads test artifacts, and validates the UPM package manifest and archive artifact..github/workflows/release.ymlthat supportsworkflow_dispatchwith a requiredversioninput andv*tag pushes, updatesPackages/com.kbanakakis.beacon/package.jsonversion, inserts a templated changelog section, tags the repo (vX.Y.Z), and creates a GitHub Release with notes derived fromCHANGELOG.md.Packages/com.kbanakakis.beacon/package.jsonto includedocumentationUrl,changelogUrl,licensesUrl, andrepositorymetadata while preserving existing fields and samples.CONTRIBUTING.mdandCHANGELOG.mdwith anUnreleasedsection andAdded / Changed / Fixedtemplate.Testing
jq . Packages/com.kbanakakis.beacon/package.jsonto validate the updated package manifest, and the check succeeded.yaml.safe_load, but the environment lackedPyYAMLso the check could not run there.Codex Task