Conversation
Collaborator
devcrocod
commented
Apr 21, 2026
- bump version to 0.2.0
- migrate to new dsl
…API for specifying docs and samples
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Multik’s documentation generation setup by bumping the Korro Gradle plugin to 0.2.0 and adapting the Korro configuration DSL, with small resulting adjustments to docs/samples formatting.
Changes:
- Bump Korro plugin version from
0.1.6to0.2.0. - Migrate
korro { ... }configuration inmultik-coreto the newdocs { from(...) }/samples { from(...) }DSL (and setbaseDirfor docs). - Minor adjustments in docs/samples to keep generated documentation content consistent.
Reviewed changes
Copilot reviewed 3 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| multik-core/src/commonTest/kotlin/samples/docs/userGuide/performanceAndOptimization.kt | Adjusts a docs sample to show consistent values inside the sample block and moves assertions outside SampleStart/SampleEnd. |
| multik-core/build.gradle.kts | Migrates Korro configuration to the new DSL and sets baseDir for docs resolution. |
| gradle/libs.versions.toml | Bumps Korro version to 0.2.0. |
| docs/topics/gettingStarted/installation.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/universal-operations.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/sum.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/statistics.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/solving-systems-of-equations.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/probability-distributions.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/ndarray-class.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/matrix-operations.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/matrix-norms.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/mathematical.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/linear-algebra.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/hypothesis-testing.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/eigenvalues-and-eigenvectors.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/descriptive-statistics.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/correlation-analysis.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/constants.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/array-operations.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/apiDocs/array-objects.md | Whitespace/formatting adjustment (list indentation). |
| docs/topics/apiDocs/array-creation.md | Whitespace/formatting adjustment (table row indentation). |
| docs/topics/apiDocs/IO-operations.md | Whitespace/formatting adjustment around </seealso>. |
| docs/topics/FAQ.md | Whitespace/formatting adjustment around </seealso>. |
Comment on lines
+20
to
+23
| println("v.consistent is ${v.consistent}") // false | ||
|
|
||
| val c = v.deepCopy() | ||
| assertTrue(c.consistent) | ||
| println("c.consistent is ${c.consistent}") // true |
There was a problem hiding this comment.
The // false / // true output comments don’t match what these println statements actually print (they print v.consistent is false and c.consistent is true). Update the expected-output comments to match, or print only the boolean values (e.g., println(v.consistent)) so the sample output stays consistent with other docs samples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.