Bugfix/integration test#6
Merged
Merged
Conversation
sha256sum -c expects the file at the path listed in checksums.txt. Downloading to cli.tar.gz caused a 'No such file or directory' error during verification.
GITHUB_PATH changes only take effect in subsequent steps, not within the same composite action step. Use export PATH instead.
Global flags (--api-url, --output, --no-color) must appear before the subcommand. Subcommand flags use single-dash syntax (-domain, -wait).
Match the CLI's pflag migration — all subcommand flags now use --double-dash syntax consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several important updates to the
entrypoint.shscript for improved compatibility with the latestkrakenkeyCLI and better handling of environment variables. The changes focus on updating command-line argument styles, improving PATH management, and refining how commands are constructed and executed.CLI Argument Style Updates:
krakenkeyCLI invocations to use the new single-dash argument style (e.g.,-domaininstead of--domain) and reordered command arguments to match the latest CLI expectations.Environment and PATH Handling:
PATHfrom appending toGITHUB_PATHto exporting a newPATHvariable directly, ensuring the CLI is available in the current shell session.Command Construction Improvements:
-auto-renewor-waitif enabled), and grouped arguments for clarity and correctness.set_outputs()function to use the new CLI argument style and command ordering for thecert showcommand.These changes ensure the script remains compatible with the evolving CLI and improve reliability in CI/CD environments.