RFC: Use ScopedValues.jl for TimerOutputs#169
Draft
vchuravy wants to merge 2 commits into
Draft
Conversation
Owner
|
Sorry for not commenting on it earlier, totally missed it. This would make it more similar to Tracy where there is only "one" profiling object where everything goes into? There is some niceness to that but it could potentially also show a lot of unrelated stuff in your dependencies I guess? Could potentially be solved with some filtering in the output function thought? |
Author
|
Yeah this mean by default there is only one root, but we could totally create a new root and not wire it up to the parent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used TimerOutputs as place to potentially use https://github.com/vchuravy/ScopedValues.jl / JuliaLang/julia#50958
This removes the need for the user to interact directly with
TimerOutputvariables.running
f(); TimerOutputs.reset_timer()This is largely just an experiment, and obviously very breaking.
If folks are interested in this I would be happy to cleanup the tests,
and docs.