fix(packaging): harden native extension validation#867
Merged
Conversation
XingYu-Zhong
marked this pull request as ready for review
July 12, 2026 05:47
Collaborator
Author
|
This PR unblocks the develop → master release PR #866. The current #866 failure is the Kun runtime typecheck error in skill-tool-provider.test.ts; this branch includes the typed ToolHostContext fix and has passed Typecheck and test, CodeQL, and native Linux/Windows/macOS packaged validation. Please review when available. |
There was a problem hiding this comment.
PR checks failed. Please fix the failing CI jobs before merging.
Failed jobs:
- Build Linux package
Run details: https://github.com/KunAgent/Kun/actions/runs/29181697794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged PR #865. It fixes the Windows thread-store path check and makes Linux AppImage validation exercise the sandboxed product entrypoint instead of a test-injected flag.
Changes
Tests
Native validation
Final head
114f4694b6b4abae8d4c7f8bac44486ce28c2431was tested through synthetic merged38090403ad4e5c7a8e50ca68c6acce18fba74b7in PR Checks run 29181030464. Typecheck/tests and all native package jobs passed, including Windows backend/Chromium, Linux userns plus direct final-AppImage Chromium, and macOS x64/arm64 backend plus host-native Chromium.The earlier commit-bound run
29180466710was independently downloaded and hash-checked; exact package bytes and SHA-256 values are recorded in the OpenSpec task evidence. This PR intentionally remains draft and does not publish a release.