fix(renderer): make workbench errors recoverable#888
Closed
luoye520ww wants to merge 2 commits into
Closed
Conversation
This was referenced Jul 14, 2026
Collaborator
Author
|
Superseded by consolidated runtime recovery PR #947, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A renderer exception previously left users with a minimal reload-only screen and could expose raw exception text. That made the #885 white-screen path difficult to recover and unsafe to report.
Root cause
AppErrorBoundaryrendered the original exception message and logged unbounded stack data without a stable incident identifier or recovery diagnostics actions.Scope
Part of #885. This PR only hardens the renderer boundary and the packaged smoke click reliability; runtime exit classification, crash-loop handling, Safe Mode, and process recovery remain separate PRs.
Changes
Safety
Typecheck
Passed locally.
Tests
npm.cmd exec vitest run src/renderer/src/components/AppErrorBoundary.test.ts node --test scripts/smoke-packaged-extension-desktop.test.cjs npm.cmd run lint -- --quiet npm.cmd run buildResults: 5 boundary tests passed; 16 packaged desktop smoke helper tests passed; lint and build passed.
CI note
The previous Linux failure timed out before the extension guest appeared; the workbench is now explicitly foregrounded before the click. The previous Windows failure was GitHub Actions infrastructure (
Failed to resolve action download info: Service Unavailable) before checkout/build, not a project failure. A real Linux/Windows packaged artifact run remains CI validation.Issue
Part of #885