feat(runtime): define managed child process contract - #903
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 13, 2026
Collaborator
Author
|
Superseded by consolidated tool/process lifecycle PR #946, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shell, LSP, Whisper, extension host, and subagent processes need one bounded lifecycle record before they can share shutdown, cancellation, and crash-recovery handling.
Root cause
The existing background shell record describes a user-facing session, but there is no cross-module contract for the actual OS child process. Reusing that record for process cleanup would mix business state with process ownership.
Scope
This PR defines and tests the shared
ManagedChildProcesscontract only. It does not register or terminate processes yet.Changes
preserveremains available for detached owners such as extension hosts.Safety
Typecheck
Passed.
Tests
Passed: 3 contract tests; root lint and build passed; diff check passed.
Review performed
Non-goals
Follow-ups
The registry and runtime integration should land as separate PRs after this contract is reviewed.