feat(ipc): define cancellation lifecycle contract#904
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by consolidated IPC/SSE reliability PR #945, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long-running IPC operations need a common cancellation lifecycle. Existing operations expose unrelated cancellation shapes, so a caller cannot reliably distinguish an observed cancel request from work that has actually stopped.
Root cause
There was no shared contract linking an operation request, its cancellation message, the cancellation acknowledgement, and the final terminal result.
Scope
This PR defines and tests the shared IPC cancellation contract only. It does not change any IPC handler or business operation.
Changes
requestIdand operation request schemas.accepted,already-terminal,unknown-request).completed,failed, andcancelledoutcomes.Safety
requestId.Typecheck
Passed.
Tests
Passed: 4 contract tests; root lint and build passed; diff check passed.
Review performed
Non-goals
Follow-ups
Each long-running operation should adopt this contract in a separate, focused PR.