feat(terminal): register PTY processes for lifecycle cleanup#906
Closed
luoye520ww wants to merge 3 commits into
Closed
feat(terminal): register PTY processes for lifecycle cleanup#906luoye520ww wants to merge 3 commits into
luoye520ww wants to merge 3 commits into
Conversation
Collaborator
Author
|
Superseded by consolidated tool/process lifecycle PR #946, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The built-in terminal owns real PTY child processes, but those PIDs were only held inside the terminal session map. Shared shutdown, cancellation, and diagnostics could not see the live process lifecycle.
Root cause
Terminal session state and OS child ownership were not connected to the managed-child registry.
Scope
This PR wires only the built-in terminal PTY path to the registry. LSP, Whisper, extension-host, and subagent integrations remain separate follow-ups.
Changes
terminal:<sessionId>identity.Safety
Typecheck
Passed.
Tests
Passed: 3 terminal lifecycle tests; root lint and build passed; diff check passed. The first test attempt before building extension workspaces was an environment resolution failure; the same test passed after the required extension build.
Review performed
Non-goals
Dependency
Depends on #905 for the managed child process registry. After #905 merges, rebase this branch onto
developand drop dependency commits.