feat(sse): persist bounded resume cursors#913
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by consolidated IPC/SSE reliability PR #945, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Renderer SSE acknowledgement state is currently in-memory. A renderer/runtime restart loses the last confirmed sequence and can replay an unnecessarily large thread window.
Root cause
There is no bounded, atomic persistence layer for per-scope resume cursors.
Scope
This PR adds only the shared cursor contract and a main-process persistence service. It is independent from IPC and renderer recovery wiring.
Changes
SseResumeCursorand file envelope schemas.Non-goals
Safety
Typecheck
npm.cmd run typecheckandnpm.cmd --prefix kun run typecheckpassed on the clean develop-based branch.Tests
npm.cmd exec vitest run src/main/services/sse-resume-cursor-store.test.ts? 1 file, 5 tests passed.Also passed:
git diff --check.Review performed
Issue
Part of #885