fix(ci): click visible packaged extension contribution#915
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 14, 2026
Collaborator
Author
|
This work is consolidated into #941, which contains the related CI diagnostics and packaged smoke fix as one tested PR. Closing this duplicate to avoid parallel review and PR noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The packaged desktop Extension smoke intermittently waits forever for the `kun-extension` guest target even though the workbench is running. The same failure has appeared on Windows and macOS package jobs, with only the renderer page visible in CDP.
Root cause
The smoke searched for the first `[data-contribution-id]` element. The same attribute is present on non-interactive wrappers and webviews as well as the actual workbench button. A wrapper could be selected and clicked, so no extension guest was created.
Scope
This PR only hardens the packaged desktop smoke contribution click. It does not change renderer behavior, extension loading, or runtime protocols.
Changes
Safety
Typecheck
```text
npm.cmd run typecheck
```
Passed.
Tests
```text
node --test scripts/smoke-packaged-extension-desktop.test.cjs
npm.cmd run lint
npm.cmd run build
git diff --check
```
Results: 17 desktop smoke tests passed; lint, build, and diff checks passed.
Actual validation
The local environment does not have a packaged cross-platform artifact, so native Windows/macOS package smoke was not claimed locally. The PR CI package jobs are the required artifact-level validation.
Review performed
Non-goals
The existing Runtime exit classification and Error Boundary PRs remain separate; this PR only fixes their shared desktop smoke harness failure.
Part of #885.