feat(storage): define safe cleanup policy#918
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #944, which consolidates storage usage reporting, safe cleanup decisions, and data-retention validation into one reviewed PR. Closing this split PR to avoid duplicate review. |
Collaborator
Author
|
Closed in favor of #944. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Storage cleanup needs an explicit fail-closed policy before any deletion service or UI can be added.
Scope
This PR only defines and tests a pure candidate decision function. It does not scan the filesystem, delete files, add IPC, or add UI.
Changes
Validation
pm.cmd exec vitest run src/main/services/storage-cleanup-policy.test.ts (3 passed)
pm.cmd run typecheck (passed)
pm.cmd --prefix kun run typecheck (passed)
pm.cmd run lint (passed)
pm.cmd run build (passed)
Review
Completed functional, lifecycle, data integrity, security, cross-platform, performance, compatibility, test quality, and scope review. The policy is pure and performs no filesystem operations.
Follow-ups
A separate cleanup service must revalidate canonical paths and candidate state immediately before deletion.