feat(storage): add schema downgrade guard#920
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
This work is consolidated into #942, which combines the Thread Store Doctor, bounded backups, and schema write guard with one tested scope. Closing the duplicate to keep review focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Older application versions must not silently write data created by a newer schema, while users still need a safe read-only view and export path.
Scope
This PR adds only a pure schema compatibility decision contract and tests. It does not change persisted formats, migrations, startup wiring, or UI.
Changes
Validation
pm.cmd exec vitest run src/main/services/schema-downgrade-guard.test.ts (3 passed)
pm.cmd run typecheck (passed)
pm.cmd --prefix kun run typecheck (passed)
pm.cmd run lint (passed)
pm.cmd run build (passed)
Review
Completed functional, lifecycle, data integrity, security, cross-platform, compatibility, test quality, and scope review. The guard never mutates persisted data.
Follow-ups
Startup read-only mode, export wiring, and migration execution belong in separate PRs.