feat(security): define network approval contract#921
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by consolidated provider/network safeguards PR #948, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Network access needs an approval contract separate from file permissions so shell, MCP, and connectors can enforce the same policy later.
Scope
This PR only adds pure request normalization and grant matching. It does not change shell execution, web fetch, MCP transport, or UI.
Changes
one, �pproved, and ull modes.
Validation
pm.cmd --prefix kun test -- src/contracts/network-approval.test.ts (4 passed)
pm.cmd run typecheck (passed)
pm.cmd --prefix kun run typecheck (passed)
pm.cmd run lint (passed)
pm.cmd run build (passed)
Review
Completed functional, lifecycle, data integrity, security, cross-platform, compatibility, test quality, and scope review. The contract performs no DNS, socket, or process operations.
Follow-ups
Shell and MCP network enforcement, audit records, and renderer approval UI should be separate PRs.