feat(network): define custom CA bundle contract#923
Closed
luoye520ww wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
The failed check is an external Electron download failure (FetchDownloader / etch failed) during the existing extension release gate. The changed contract itself passes the local root/Kun typechecks, lint, build, and targeted tests. I am rerunning the failed job; no unrelated runtime change is being added to this PR. |
Collaborator
Author
|
Superseded by consolidated provider/network safeguards PR #948, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enterprise networks may require a user-selected CA bundle, but the project has no shared validation contract. This PR establishes the safe boundary before runtime wiring.
Scope
Adds a strict shared Custom CA bundle contract with absolute cross-platform path validation, optional SHA-256 fingerprint normalization, bounded path length, and control-character rejection. Disabled settings cannot retain certificate metadata.
Non-goals
No TLS agent wiring, proxy changes, settings UI, or certificate file reads are included; those will be separate PRs.
Safety
The contract intentionally does not expose PEM contents and rejects unknown fields including insecureSkipVerify.
Tests
Review
Completed functional, data integrity, security, cross-platform, compatibility, and scope review. No package smoke is claimed because this is a shared contract-only change.
Issue
Part of #885