feat(budget): define model budget contract#924
Closed
luoye520ww wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by consolidated provider/network safeguards PR #948, which passed Typecheck, Linux, macOS, and Windows packaged checks. Closing this duplicate to keep the review surface focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Kun already enforces a thread cost limit, but there is no shared contract for turn, thread, provider, agent, and workflow budgets. Different integrations could otherwise implement warning and denial semantics inconsistently.
Scope
Adds a pure model-budget contract and evaluator for the five budget scopes. It validates finite positive limits, bounded warning ratios, non-negative usage, rejects unknown fields, and returns deterministic allow/warn/deny decisions with remaining budget.
Non-goals
This PR does not change existing thread persistence, UI, model routing, provider queues, or automatic model switching. Those integrations remain separate follow-up PRs.
Tests
Review
Completed functional, concurrency/lifecycle, data integrity, security, compatibility, and scope review. No package smoke is claimed because this PR is a pure contract module.
Issue
Part of #885