Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a DataMapper pool feature to provide efficient reuse of DataMapper instances across threads. The implementation supports three growth strategies (UnboundedGrow, BoundedWait, and BoundedOverflow) that can be configured at compile time, along with a global singleton pool accessible via GlobalDataMapperPool().
Changes:
- Adds a template-based
Poolclass with RAII wrapperPooledDataMapperfor automatic resource management - Implements three configurable growth strategies for different use cases
- Provides CMake configuration options for pool sizing and growth strategy
- Adds comprehensive unit tests covering all strategies and concurrent usage scenarios
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Lightweight/DataMapper/Pool.hpp | Core pool implementation with template-based configuration and strategy pattern |
| src/Lightweight/DataMapper/Pool.cpp | Global singleton pool implementation |
| src/Lightweight/Lightweight.hpp | Exposes Pool.hpp in public API |
| src/Lightweight/CMakeLists.txt | Adds CMake configuration options and compile definitions for pool settings |
| src/tests/DataMapper/AsynchronousTests.cpp | Adds comprehensive tests for all pool strategies and concurrent usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
christianparpart
left a comment
There was a problem hiding this comment.
Documentation is missing on every public type and member. This has an impact also on our documentation website.
f7d7ce1 to
b4bf808
Compare
|
Added documentation |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6199e47 to
ace590d
Compare
ace590d to
bdd471e
Compare
Closes #432