Enforce API payload size limits and query result caps (#1630)#1925
Draft
AkramBitar wants to merge 1 commit into
Draft
Enforce API payload size limits and query result caps (#1630)#1925AkramBitar wants to merge 1 commit into
AkramBitar wants to merge 1 commit into
Conversation
…1630) Add upper bounds at the SQL transaction-store chokepoint so a single oversized write or unbounded scan cannot monopolise DB resources: - Write cap: AddTokenRequest/AddTransaction/AddMovement reject payloads over a max size (DefaultMaxPayloadSize 4 MiB; 0 disables). - Read caps: QueryTransactions requires bounded pagination (rejects nil/None); QueryTokenRequests is hard-LIMITed to the max page size (DefaultMaxPageSize 1000). QueryMovements is intentionally excluded. - Limits default via consts and are overridable from config (token.storage.maxPayloadSize / maxPageSize) or WithMax* options. - Migrate unbounded callers (checks.go, history views) to page loops. Signed-off-by: AkramBitar <akram@il.ibm.com>
AkramBitar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce upper bounds at the SQL transaction-store chokepoint so a single oversized write or unbounded scan cannot monopolise DB resources.
AddTokenRequest/AddTransaction/AddMovementreject payloads over a max size (default 4 MiB; 0 disables).QueryTransactionsrequires bounded pagination (rejects nil/None);QueryTokenRequestsis hard-LIMITed to the max page size (default 1000).QueryMovementsis intentionally excluded (balance aggregation).token.storage.maxPayloadSize/maxPageSize) orWithMax*options.Closes #1630.