docs(token): document RestRecipientIdentity and TransferActionMetadataKeyPrefix#1926
Open
adecaro wants to merge 1 commit into
Open
docs(token): document RestRecipientIdentity and TransferActionMetadataKeyPrefix#1926adecaro wants to merge 1 commit into
adecaro wants to merge 1 commit into
Conversation
…aKeyPrefix Both symbols carried a placeholder "TODO" Godoc instead of a real description. Fill them in based on their actual usage and add corresponding notes to docs/tokenapi.md and docs/services/network-fabric.md. Fixes #1924 Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransferOptions.RestRecipientIdentity(token/request.go) andKeyTranslator.TransferActionMetadataKeyPrefix(token/services/network/common/rws/translator/rwset.go) with descriptions derived from their actual usage.docs/tokenapi.md(transfer rest/change recipient handling) anddocs/services/network-fabric.md(delivery-based lookup listener prefix matching).Fixes #1924
Test plan
go build ./token/...make checksgofmt -lon changed Go files (clean)grep -n "TODO"on the changed files (the unrelatedHashedKeyTranslatorimplementation stub TODO remains, intentionally out of scope)