fix(deploy): wire DOCKER_IMAGE_LIT_ACTIONS_GVISOR through the deploy path#580
Merged
Conversation
…path
The lit-actions-gvisor service in docker-compose.phala.yml referenced
${DOCKER_IMAGE_LIT_ACTIONS_GVISOR}, but nothing built, pushed, or substituted
it, so the placeholder rendered literally and the service was undeployable.
Add Dockerfile.lit-actions-gvisor (supervisor + runsc + exported sandbox
rootfs), the image_lit_actions_gvisor justfile var, gvisor build/push/digest
and sed substitution across justfile.deploy (deploy, deploy-new,
docker-run-local), and the build matrix + substitution in the staging and
prod-propose workflows.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the deploy pipeline for the lit-actions-gvisor service by introducing a dedicated gVisor runner image and wiring its image tag/digest through local just deploy flows and the staging + prod stage-1 GitHub Actions workflows, so ${DOCKER_IMAGE_LIT_ACTIONS_GVISOR} no longer renders literally in the compose file.
Changes:
- Add
Dockerfile.lit-actions-gvisorto build a gVisor runner image (supervisor +runsc+ exported sandbox rootfs). - Add
image_lit_actions_gvisorand thread it throughjustfile.deploybuild/push/digest capture + compose substitution + local compose run. - Extend staging and prod stage-1 workflows to build/push/sign the new image and substitute its digest into the deployment compose.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
justfile.deploy |
Builds/pushes/captures digest for lit-actions-gvisor and substitutes ${DOCKER_IMAGE_LIT_ACTIONS_GVISOR} for deploy paths. |
justfile |
Introduces image_lit_actions_gvisor variable for consistent tagging. |
Dockerfile.lit-actions-gvisor |
New multi-stage image for gVisor runner (supervisor + rootfs export + runsc install). |
.github/workflows/deploy-staging.yml |
Adds gVisor image to build matrix and compose substitution for staging deploy. |
.github/workflows/deploy-prod-1-propose.yml |
Adds gVisor image to build matrix and compose substitution for prod stage-1 propose flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add Dockerfile.lit-actions-gvisor to staging DEPLOY_PATHS and prod IMAGE_PATHS so changes to it alone trigger a rebuild / staging soak. - Point the digest-missing error messages at `just docker-push` (the recipe that actually captures the digests), not docker-build. - Reword the GVISOR_RELEASE comment to state the default is mutable `latest` and callers should override it to pin a reproducible release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lit-actions-gvisorservice indocker-compose.phala.ymlreferenced${DOCKER_IMAGE_LIT_ACTIONS_GVISOR}, but no deploy path built, pushed, or substituted it — the placeholder rendered literally, leaving the gVisor runner undeployable. This addsDockerfile.lit-actions-gvisor(supervisor binary +runsc+ an exported shared sandbox rootfs at/var/lib/lit/sandbox-rootfs) and theimage_lit_actions_gvisorjustfile var. It wires the gvisor image through build/push/digest-capture and thesedsubstitution injustfile.deploy(deploy,deploy-new,docker-run-local) and into the build matrix + substitution of both the staging and prod-propose workflows. Prod stage 2 is unchanged — it consumes stage 1's pre-rendered artifacts. Note: the compose_hash changes (a governed prod change, handled by the propose→Safe→execute flow), and the gVisor release is pinned via a build ARG defaulting tolatest— pin a validated release before production.🤖 Generated with Claude Code