feat: Parquet format and rolling retention for rollout debug saves#24
Merged
Conversation
…aves Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nightlessbaron
commented
May 18, 2026
odp
reviewed
May 18, 2026
odp
reviewed
May 18, 2026
|
@nightlessbaron in def _get_rollout_data(self, rollout_id):
if self.args.load_debug_rollout_data:
data = torch.load(
self.args.load_debug_rollout_data.format(rollout_id=rollout_id),
weights_only=False,
)["samples"]the |
Author
|
made |
odp
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new flags to
--save-debug-rollout-data:--save-rollout-format {pt,parquet}— write snappy-compressed parquet instead of.pt; rollout_id stored in schema metadata. Defaultptkeeps existing behaviour.--save-rollout-retain-last-n N— after each training rollout, delete the file for stepR-N. O(1), no directory scan. Default0keeps all files.Eval rollouts (
eval_*) are excluded from the retention window.Diagnostics are written by @odp. We might remove them in the future depending on how compute intensive they are.