fix: upload timeout false failure in wardrive_upload#6
Open
FusedStamen wants to merge 11 commits intoLOCOSP:mainfrom
Open
fix: upload timeout false failure in wardrive_upload#6FusedStamen wants to merge 11 commits intoLOCOSP:mainfrom
FusedStamen wants to merge 11 commits intoLOCOSP:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Large sessions with many ADS-B records could exceed the 30s upload timeout.
The upload succeeded server-side but the client received a timeout error,
logged it as failed, and left the session unmarked — causing duplicate
re-uploads on retry which the server correctly rejected as "already seen".
Fix
with a warning instead of silently failing — prevents duplicate re-sends when
the server received the data but the response timed out