Remove selfcal from split-directions - #123
Closed
tikk3r wants to merge 0 commit into
Closed
Conversation
lonbar
reviewed
May 27, 2026
lonbar
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Two minor comments.
Member
|
@tikk3r there does seem to be a validation issue unrelated to the Python versioning. |
Member
Author
Ah yes, delay-calibration fails because |
tikk3r
force-pushed
the
remove-selfcal-splitdir
branch
from
May 28, 2026 07:47
3daf315 to
5ce976d
Compare
Member
Author
|
I accidentally included these changes in the merging of #113 so they have already been merged. My bad... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the self-cal options from the split-directions workflow. The reasoning is as follows:
dd-calibration.cwlworkflow nowthe_only_non_null, but they will be null if skippedsplit-directions.cwlmore true to its name by simply covering the job of splitting off various directions with the relevant corrections.