Skip to content

Remove selfcal from split-directions - #123

Closed
tikk3r wants to merge 0 commit into
masterfrom
remove-selfcal-splitdir
Closed

Remove selfcal from split-directions#123
tikk3r wants to merge 0 commit into
masterfrom
remove-selfcal-splitdir

Conversation

@tikk3r

@tikk3r tikk3r commented May 27, 2026

Copy link
Copy Markdown
Member

This PR removes the self-cal options from the split-directions workflow. The reasoning is as follows:

  • Pilot has a dedicated dd-calibration.cwl workflow now
  • No other steps in the pipeline use the selfcal output from this workflow
  • This selfcal being skipped is causing issues for people to run the pipeline (see the Slack channel discussions) because the output selection is the_only_non_null, but they will be null if skipped
  • It will make split-directions.cwl more true to its name by simply covering the job of splitting off various directions with the relevant corrections.

@lonbar lonbar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two minor comments.

Comment thread workflows/split-directions.cwl Outdated
Comment thread workflows/split-directions.cwl Outdated
@lonbar

lonbar commented May 27, 2026

Copy link
Copy Markdown
Member

@tikk3r there does seem to be a validation issue unrelated to the Python versioning.

@tikk3r

tikk3r commented May 27, 2026

Copy link
Copy Markdown
Member Author

@tikk3r there does seem to be a validation issue unrelated to the Python versioning.

Ah yes, delay-calibration fails because find-best-delay-calibrator.cwl fails, which is because #113 is not merged yet. That branch takes care of that (I did a quick check with a local rebase of auto-auto-delay on this branch).

@tikk3r tikk3r closed this May 28, 2026
@tikk3r
tikk3r force-pushed the remove-selfcal-splitdir branch from 3daf315 to 5ce976d Compare May 28, 2026 07:47
@tikk3r

tikk3r commented May 28, 2026

Copy link
Copy Markdown
Member Author

I accidentally included these changes in the merging of #113 so they have already been merged. My bad...

@tikk3r
tikk3r deleted the remove-selfcal-splitdir branch May 28, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants