Skip to content

Refactor: Remove socketmap handler and thunder integration#305

Merged
maneeshaxyz merged 1 commit intoLSFLK:mainfrom
Aravinda-HWK:304-task-remove-socketmap-service-from-silver-repo
Mar 21, 2026
Merged

Refactor: Remove socketmap handler and thunder integration#305
maneeshaxyz merged 1 commit intoLSFLK:mainfrom
Aravinda-HWK:304-task-remove-socketmap-service-from-silver-repo

Conversation

@Aravinda-HWK
Copy link
Collaborator

📌 Description

This PR is to remove the socketmap service from the silver repo and move it to the raven repo.


🔍 Changes Made

  • Removed entire socketmap service from the silver repo to the raven repo.
  • Update the docket compose file by removing the socketmap service
  • Update the Postfix config generation to use Raven

✅ Checklist (Email System)

  • Core services tested (SMTP, IMAP, mail storage, end-to-end delivery)
  • Security & compliance verified (auth via Thunder IDP, TLS, DKIM/SPF/DMARC, spam/virus filtering)
  • Configuration & deployment checked (configs generated, Docker/Compose updated)
  • Reliability confirmed (error handling, logging, monitoring)
  • Documentation & usage notes updated (README, deployment, API)

🧪 Testing Instructions


📷 Screenshots / Logs (if applicable)


⚠️ Notes for Reviewers

- Deleted handler functions for domain and user existence checks.
- Removed netstring protocol handling from the server.
- Eliminated Thunder authentication and user validation logic.
- Cleaned up related types and utility functions.
- Streamlined the main application entry point by removing unnecessary components.
@Aravinda-HWK Aravinda-HWK self-assigned this Mar 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's service architecture by eliminating the standalone socketmap service from the silver repository. Its core functionality, which provides dynamic virtual mailbox maps backed by Thunder IDP, has been migrated and integrated into the existing raven service. This consolidation simplifies the deployment and management of services by centralizing related components and updating all necessary configurations to reflect the new service dependency.

Highlights

  • Socketmap Service Removal: The entire socketmap service, previously responsible for Postfix virtual mailbox maps, has been removed from the silver repository.
  • Docker Compose Refactoring: The Docker Compose configuration was updated to remove the socketmap-server definition and integrate its environment variables and port exposure directly into the raven-server.
  • Postfix Configuration Update: Postfix configuration generation was modified to direct all socketmap lookups (for domains, users, and aliases) to the raven service instead of the now-removed socketmap-server.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The socketmap-server service, which provided dynamic virtual mailbox maps for Postfix, has been entirely removed. Its functionality, including configuration, caching, and integration with Thunder IDP for user, domain, and alias lookups, has been absorbed into the raven-server. This change is reflected across docker-compose.yaml where the socketmap-server service definition and related volume mounts are removed, and the raven-server now exposes the socketmap port (9100) and inherits the necessary environment variables and Docker socket mount. The Postfix configuration script (gen-postfix-conf.sh) has been updated to point to raven:9100 for socketmap services, indicating a consolidation of these mail-related functionalities within the raven-server.

Copy link
Member

@maneeshaxyz maneeshaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maneeshaxyz maneeshaxyz merged commit c0bf71a into LSFLK:main Mar 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Remove Socketmap Service from Silver Repo

2 participants