add notebook comparing SLSim lenses to SLACS Dinos and SLED lenses#353
add notebook comparing SLSim lenses to SLACS Dinos and SLED lenses#353mia-lamontagne wants to merge 2 commits intoLSST-strong-lensing:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:19Z can you refer to the Dinos papers and the SLED website? |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:19Z can you comment from where this file was retrieved? |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:20Z Line #1. slacs_data = pd.read_csv("dinos1_lens_data.csv")
is this column duplicated? |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:21Z can you make a title similar to the plot at the end? |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:21Z Line #4. light_df = pd.read_csv("SLACS_light_params.csv")
can you comment from where this file can be retrieved? |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:22Z Line #1. def compute_ab_mag_from_row(row, photflam, photzpt, photplam): can you make a better definition documentation? |
|
View / edit / reply to this conversation on ReviewNB sibirrer commented on 2025-08-07T18:13:23Z Line #3. slacs_data = pd.read_csv("dinos1_lens_data.csv")
is this a duplicate import? |
|
@mia-lamontagne pre-commit CI is complaining about some stylistic aspects of your notebook: https://results.pre-commit.ci/run/github/454145089/1754589068.uFYR7i2YQ4uRhLHXD56QWA |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 97.93% 98.27% +0.33%
==========================================
Files 154 98 -56
Lines 10479 6420 -4059
==========================================
- Hits 10263 6309 -3954
+ Misses 216 111 -105 🚀 New features to boost your workflow:
|
|
Hi @mia-lamontagne , thank you very much for this PR! The notebook looks very good. Pre-commit is failing. Would be great if you could fix them! |
3 participants
This notebook compares various parameters of simulated SLSim lenses with both real SLACS Dinos lenses and SLED lenses. These comparisons are then visualized in corner plots for analysis.