Pull request for simulation-based inference tutorial notebook#355
Pull request for simulation-based inference tutorial notebook#355StevenDillmann wants to merge 14 commits intoLSST-strong-lensing:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 98.21% 98.19% -0.02%
==========================================
Files 98 98
Lines 6485 6485
==========================================
- Hits 6369 6368 -1
- Misses 116 117 +1 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,451 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,451 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #3. # TODO: Change this to the path to the data folder on your machine
Might be good to put slsim code that you used to generate this data??
Reply via ReviewNB
There was a problem hiding this comment.
Hi @nkhadka21, thank you for all your feedback. I addressed all issues except this one. Currently, I am just using a dataset from Sydney. Padma and I discussed generating a separate dataset for the tutorial, but this will take some time before I can change that. The main functionality will remain the same and users will just be able to use any dataset they created (from other notebook tutorials for example) and simply change the path to their data and run the notebook. I'll send in another PR soon.
There was a problem hiding this comment.
Thank you for addressing my comments. If we put this notebook in the current version, it will look like a notebook for the application of SBI, not SLSim. So, I would really like to have the code that generates the data using SLSim, so that it will be a combination of both the SLSim and SBI notebooks. No hurry—please take your time.
|
Hi @StevenDillmann , thank you very much for this PR! PR looks good. I have some minor comments. Please address them. Also, pre-commit is failing. Please fix it. |
StevenDillmann
force-pushed
the
sbi-tutorial-branch
branch
from
e8b6cc1 to
9b9aab6
Compare
|
Fixed pre-commit issues! |
2 participants
Pull request for simulation-based inference tutorial notebook, demonstrating how to use the sbi package for strong lensing inference, including diagnostics visualizations.