added pip and testmon db caching for speed ups during tests#369
added pip and testmon db caching for speed ups during tests#369jacob-hjortlund wants to merge 10 commits intoLSST-strong-lensing:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 98 98
Lines 6520 6520
=======================================
Hits 6402 6402
Misses 118 118 🚀 New features to boost your workflow:
|
sibirrer
left a comment
There was a problem hiding this comment.
Thank you very much @jacob-hjortlund ! (I am currently a bit slow due to a newborn).
I have one minor request.
The CI failed due to something unrelated that is not as stable (did not find a halo in the sky area). If you re-trigger the test, chances are that it passes (and need to be made more stable, but not your issue).
| assert catalog.colnames[3] == column_names[3] | ||
|
|
||
|
|
||
| def test_testmon(): |
There was a problem hiding this comment.
can you describe what tests are being executed here and why? It is just unclear to me but might be helpful
There was a problem hiding this comment.
Sorry, this test was added after my first push. The point was to see if only this test was run, or if everything was rerun, i.e. actually checking if testmon is doing what is should. It'll be removed later in this PR.
Thanks, I thought that was the case. I was planning on seeing if I could fix a seed to remove the flakiness of the test, but have been busy with some travel + #365. Hope everything is going well with the newborn! 😄 |
|
I reassign @nkhadka21 here to help you out |
PR implementing #366 with caching of testmon database as well as pip