Skip to content

added pip and testmon db caching for speed ups during tests#369

Open
jacob-hjortlund wants to merge 10 commits intoLSST-strong-lensing:mainfrom
jacob-hjortlund:feature/testmon
Open

added pip and testmon db caching for speed ups during tests#369
jacob-hjortlund wants to merge 10 commits intoLSST-strong-lensing:mainfrom
jacob-hjortlund:feature/testmon

Conversation

@jacob-hjortlund
Copy link
Collaborator

PR implementing #366 with caching of testmon database as well as pip

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.19%. Comparing base (c8cbf0b) to head (e236ee1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files          98       98           
  Lines        6520     6520           
=======================================
  Hits         6402     6402           
  Misses        118      118           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @jacob-hjortlund ! (I am currently a bit slow due to a newborn).
I have one minor request.
The CI failed due to something unrelated that is not as stable (did not find a halo in the sky area). If you re-trigger the test, chances are that it passes (and need to be made more stable, but not your issue).

assert catalog.colnames[3] == column_names[3]


def test_testmon():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you describe what tests are being executed here and why? It is just unclear to me but might be helpful

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this test was added after my first push. The point was to see if only this test was run, or if everything was rerun, i.e. actually checking if testmon is doing what is should. It'll be removed later in this PR.

@jacob-hjortlund
Copy link
Collaborator Author

Thank you very much @jacob-hjortlund ! (I am currently a bit slow due to a newborn). I have one minor request. The CI failed due to something unrelated that is not as stable (did not find a halo in the sky area). If you re-trigger the test, chances are that it passes (and need to be made more stable, but not your issue).

Thanks, I thought that was the case. I was planning on seeing if I could fix a seed to remove the flakiness of the test, but have been busy with some travel + #365. Hope everything is going well with the newborn! 😄

@sibirrer
Copy link
Contributor

I reassign @nkhadka21 here to help you out

@sibirrer sibirrer requested a review from nkhadka21 September 24, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants