Skip to content

Fix HDF5 configuration by removing system installations and setting HDF5_ROOT #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 7 commits into from
Closed

Fix HDF5 configuration by removing system installations and setting HDF5_ROOT #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f9a445
Initial plan
Copilot Oct 8, 2025
15f01c2
Add robust HDF5 configuration to lxelsim package
Copilot Oct 8, 2025
f87171c
Merge branch 'main' into copilot/fix-hdf5-configuration-issue
madbaron Oct 8, 2025
1885565
Merge branch 'main' into copilot/fix-hdf5-configuration-issue
madbaron Oct 8, 2025
fb595cb
Merge branch 'main' into copilot/fix-hdf5-configuration-issue
madbaron Oct 8, 2025
c9da941
Simplify HDF5 configuration to only set HDF5_ROOT
Copilot Oct 8, 2025
14b987a
Remove system HDF5 installations from Docker image
Copilot Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,19 @@ RUN apt-get update && \
apt-get install -y lsb-release wget software-properties-common gnupg && \
bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)"

# Remove any system HDF5 installations to prevent CMake from finding them
RUN apt-get remove -y libhdf5-* hdf5-* || true && \
apt-get autoremove -y && \
rm -rf /usr/lib/x86_64-linux-gnu/libhdf5* \
/usr/lib/x86_64-linux-gnu/hdf5 \
/usr/lib/aarch64-linux-gnu/libhdf5* \
/usr/lib/aarch64-linux-gnu/hdf5 \
/usr/lib/libhdf5* \
/usr/include/hdf5* \
/usr/share/hdf5* \
/usr/local/lib/libhdf5* \
/usr/local/include/hdf5* || true

# Apply our patches to spack
RUN . /opt/setup_spack.sh && \
REPOPATH=${SPACK_ROOT}/var/luxe-spack && \
Expand Down
9 changes: 6 additions & 3 deletions packages/lxelsim/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Lxelsim(CMakePackage, Key4hepPackage):
git = "https://github.com/LUXEsoftware/lxelsim.git"
url = "https://github.com/LUXEsoftware/lxelsim/archive/refs/tags/v00-01.tar.gz"

maintainers = ['']
maintainers = ['madbaron']

version('master', branch='master')

Expand All @@ -18,7 +18,10 @@ class Lxelsim(CMakePackage, Key4hepPackage):
depends_on('hdf5')

def cmake_args(self):
args = []
args = []
args.append(self.define('CMAKE_CXX_STANDARD', '20'))
#args.append(self.define('BUILD_TESTING', self.run_tests))

# Set HDF5_ROOT to prevent CMake from picking up system HDF5
args.append(self.define('HDF5_ROOT', self.spec['hdf5'].prefix))

return args
Loading