Skip to content

Comments

Avoid adding the same items multiple times into the same menu#21

Open
marcosalcazar wants to merge 3 commits intoLaLogiaDePython:masterfrom
marcosalcazar:master
Open

Avoid adding the same items multiple times into the same menu#21
marcosalcazar wants to merge 3 commits intoLaLogiaDePython:masterfrom
marcosalcazar:master

Conversation

@marcosalcazar
Copy link

I have found the same items being added to the same submenu multiple times on each page refresh. This is a fix for that.

@MiltonLn
Copy link
Member

Hello @marcosalcazar thanks for the contribution, before we can consider it ready, we need to add a test that demonstrates the problem first. Do you think that's something you can do?

@marcosalcazar
Copy link
Author

marcosalcazar commented Nov 16, 2020 via email

@yamijuan
Copy link
Member

Hi @marcosalcazar , any chance you can add a test?

@marcosalcazar
Copy link
Author

@MiltonLn @yamijuan Hello! I've added a small test to make sure the menu is the same after two requests, do you think this is enough? Without my change the test fails.

Spawin added a commit to Spawin/django-menu-generator that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants