Issue 436: Stop trying to resolve sample file fields by RowId #7340
+25
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Jan 19, 2026
labkey-susanh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 436 The logic for resolving file links field data allows for the possibility of users providing the rowId for the file in the
exp.datatable, which is something that may (or may not) be relied upon for assay data import. If a user happens to name a file with just a number (123) and that number happens to coincide with a rowId in theexp.datatable, the incorrect file will be chosen to associate with that File field. Since we don't believe anyone importing or updating sample file fields will rely on the ability to resolve by RowId, we make a change here to skip that conversion logic for sample file fields.Related Pull Requests
Changes
ExpDataFielConverter.convertthat take a parameter indicating if resolution by RowId should be tried.ExpDataIterators::FileLinkDataIterator