Skip to content

Conversation

@Tim-Kerr
Copy link
Contributor

@Tim-Kerr Tim-Kerr commented Dec 4, 2025

Description

Added a new "group" type for classifications.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

Note

Introduces support for group classifications.

  • Adds GROUP to Classification.Type in classification.py
  • No changes to option requirements (_REQUIRES_OPTIONS remains checklist/radio)

Written by Cursor Bugbot for commit a43a728. This will update automatically on new commits. Configure here.

Copy link
Contributor

@paulnoirel paulnoirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

TEXT = "text"
CHECKLIST = "checklist"
RADIO = "radio"
GROUP = "group"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GROUP classification type may need options requirement

Medium Severity

The new GROUP classification type is not added to _REQUIRES_OPTIONS, allowing creation of GROUP classifications without any options. Semantically, a "group" implies grouping items together, which would require options to be meaningful. An empty GROUP classification (with nothing to group) may result in invalid ontologies or unexpected behavior during labeling. If GROUP is intended to behave like CHECKLIST/RADIO, it needs to be added to _REQUIRES_OPTIONS.

Additional Locations (1)

Fix in Cursor Fix in Web

@paulnoirel paulnoirel merged commit cc00906 into develop Jan 19, 2026
43 of 46 checks passed
@paulnoirel paulnoirel deleted the feature-schema-groups branch January 19, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants