Skip to content

[PTDT-4832] Prelabels for text subclasses under global text classes #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgluszek merged 1 commit into from
Jan 31, 2026
Merged

[PTDT-4832] Prelabels for text subclasses under global text classes #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/labelbox/src/labelbox/data/annotation_types/classification/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class Text(ConfidenceMixin, CustomMetricsMixin, BaseModel):
"""

answer: str
classifications: Optional[List["ClassificationAnnotation"]] = None


class ClassificationAnnotation(
Expand Down
18 changes: 18 additions & 0 deletions libs/labelbox/src/labelbox/data/serialization/ndjson/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ def to_common(self) -> Text:
answer=self.answer,
confidence=self.confidence,
custom_metrics=self.custom_metrics,
classifications=[
NDSubclassification.to_common(annot)
for annot in self.classifications
]
if self.classifications
else None,
)

@classmethod
Expand All @@ -98,6 +104,12 @@ def from_common(
schema_id=feature_schema_id,
confidence=text.confidence,
custom_metrics=text.custom_metrics,
classifications=[
NDSubclassification.from_common(annot)
for annot in text.classifications
]
if text.classifications
else None,
)


Expand Down Expand Up @@ -245,6 +257,12 @@ def from_common(
message_id=message_id,
confidence=text.confidence,
custom_metrics=text.custom_metrics,
classifications=[
NDSubclassification.from_common(annot)
for annot in text.classifications
]
if text.classifications
else None,
Copy link

@cursor cursor bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing serializer to remove empty classifications in NDText

Low Severity

NDText is missing the serialize_model method that NDChecklist and NDRadio have to remove empty classifications from serialized output. When NDText has classifications=[] (e.g., from deserializing ndjson with an empty list), it will serialize with "classifications": [], while NDChecklist and NDRadio would omit the key entirely. This creates inconsistent serialization behavior across classification types.

Additional Locations (2)

Fix in Cursor Fix in Web

)


Expand Down
Loading