fix(frontend): expose active settings section to assistive tech (#1231)#1277
Merged
ogazboiz merged 2 commits intoJun 28, 2026
Merged
Conversation
Add tablist/tab/tabpanel semantics with aria-selected and aria-controls so screen readers can identify the active panel. Keyboard focus stays on the active tab when switching sections, with arrow-key navigation between tabs. Assert active state via accessible attributes in unit tests. Closes LabsCrypt#1231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-selected,aria-controls, and rovingtabIndexCloses #1231
Test plan
npm test -- --testPathPattern=settings/page.testaria-selectedupdate