Add missing queryKeys factory entries and fix misleading hook JSDoc#1282
Open
wheval wants to merge 1 commit into
Open
Add missing queryKeys factory entries and fix misleading hook JSDoc#1282wheval wants to merge 1 commit into
wheval wants to merge 1 commit into
Conversation
…JSDoc - queryKeys: add creditScore, creditScoreHistory, yieldHistory, remittanceNft, notificationPreferences, and amortization namespaces so every hook can use typed, factory-generated keys instead of ad-hoc string arrays (LabsCrypt#1222) - Replace all inline queryKey literals in useCreditScore, useCreditScoreHistory, useYieldHistory, useRemittanceNft, useNotificationPreferences, useLoanAmortizationSchedule, and useLoanAmortizationPreview with the new factory calls (LabsCrypt#1222) - useDepositToPool / useWithdrawFromPool: clarify in JSDoc that mutationFn only builds an unsigned XDR and must be paired with signTransaction + submit (LabsCrypt#1224) - useRepayLoan: clarify that it is a full server-side submit, not build-only (LabsCrypt#1224) Closes LabsCrypt#1222 Closes LabsCrypt#1224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #1222
Closes #1224