fix: audit log deep redaction and status capture#1287
Open
SharifIbrahimDev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1183
What does this PR do?
This PR addresses the security vulnerability where audit logs recorded the request but never the outcome, and where deep secrets could leak into the database because of shallow payload redaction.
Description
sanitizePayloadlogic inauditLog.tsto recursively scan objects and arrays, safely redacting keys defined insensitiveFields(likesecret,token,signedTxXdr) at any nested depth.status(integer) column to theaudit_logstable.res.on('finish')event, accurately capturing the finalres.statusCoderepresenting success (200) or denial (403/400).auditLog.test.tsto simulate deep nested secrets and denied requests. Also updatedeventIndexertest logic and assertions to account for the new column schema.Note
A few unrelated endpoints in
loanEndpoints.test.tsand background jobs were failing locally on the main branch before these changes, butauditLog.tsandeventIndexer.tsrelated tests passed with flying colors.