fix: enforce 100kb payload limit on express.json and handle 413s#1288
Open
SharifIbrahimDev wants to merge 1 commit into
Open
fix: enforce 100kb payload limit on express.json and handle 413s#1288SharifIbrahimDev wants to merge 1 commit into
SharifIbrahimDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1184
What does this PR do?
This PR enforces an explicit 100kb payload size limit on
express.json()and correctly handles resultingentity.too.largeerrors so they return a structured 413 response rather than defaulting to an unhandled 500 error.Description
{ limit: '100kb' }configuration toexpress.json()inapp.ts. This protects the application and audit logs from unbounded payload sizes, while remaining more than generous enough to accommodate legitimate signed transaction payloads.errorHandler.tsto natively catchentity.too.largeerrors emitted bybody-parserand translate them into standard413 Payload Too Largeresponses with theVALIDATION_ERRORcode.errorHandling.test.tsto assert that a 150kb payload correctly trips the limit and returns the structured413error.app.ts.