fix: drop broken loan_events FK from loan_disputes migration#1289
Open
SharifIbrahimDev wants to merge 1 commit into
Open
fix: drop broken loan_events FK from loan_disputes migration#1289SharifIbrahimDev wants to merge 1 commit into
SharifIbrahimDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1191
What does this PR do?
This PR resolves a database migration failure where
loan_disputesattempted to create a foreign key referencingloan_events(loan_id). Becauseloan_events.loan_idlacks a total unique constraint and acts as an append-only event log (and is later renamed to a view viacontract_events), PostgreSQL rejects the foreign key.Description
REFERENCES loan_events(loan_id)constraint from theloan_disputesschema migration. The schema now relies on application-level validation forloan_idassociations, which is already handled seamlessly by the existing robust controllers and indexed events flow.loan_disputesmigration will apply cleanly, unaffected by theloan_events->contract_eventsrename or the view creation that happens in subsequent migrations.loanDisputesSchema.test.ts) that asserts an actual dispute record can be cleanly inserted against the real database schema.