fix: harden surface nets arithmetic and optimize density smoothing#1
Merged
Conversation
- Replace isize arithmetic in gradient_and_ao_at_cell() with safe coordinate-based usize indexing for 26-neighbor reads - Eliminate copy_from_slice and swap in density smoothing by reordering ping-pong passes so result lands directly in density - Make blend_dist configurable via set_blend_dist() (default 4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gradient_and_ao_at_cell()with safe coordinate-based usize indexing for 26-neighbor readscopy_from_sliceandswapin density smoothing by reordering ping-pong passesblend_distconfigurable viaset_blend_dist()(default 4.0)Test plan
cargo test(72/72 pass)cargo clippy --all-targets -- -D warningscargo fmt --all -- --checkcargo checkon urath-wasm