ci: exclude build directories from Windows Defender in minimal CI#661
Merged
Merged
Conversation
freya0926
force-pushed
the
ci/windows-defender-exclusions
branch
from
d44a562 to
2dcc047
Compare
adsharma
reviewed
Jul 7, 2026
The main CI's Windows job is the only long-running Windows workflow without Defender exclusions; java, nodejs, python-wheel, extensions, and precompiled-bin workflows already apply them. Also excludes the ccache dirs (D:\c, D:\t) used by this job. Fixes LadybugDB#61 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
adsharma
force-pushed
the
ci/windows-defender-exclusions
branch
from
2dcc047 to
0817bf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61
The Windows job in the minimal CI (
ci-workflow.yml) does a full C++ build + ctest onwindows-2022and is the slowest job in the matrix, but it is the only long-running Windows workflow without Windows Defender exclusions —java-workflow.yml,nodejs-workflow.yml,python-wheel-workflow.yml,build-extensions.yml, andprecompiled-bin-workflow.ymlalready apply them.What's changed
Added a
Configure Windows Defender exclusions (Windows)step (pwsh, guarded bymatrix.platform == 'windows'like the adjacentEnable long pathsstep) using the snippet from #61:${{ github.workspace }}— covers the build directory$env:TEMPD:\candD:\t— the ccache cache/temp dirs this job configures, which see heavy small-file I/OThis completes Defender-exclusion coverage across all Windows CI workflows.
🤖 Generated with Claude Code