Skip to content

Fix wrong CASE WHEN values for bool references #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Jul 7, 2026
+12 −5
Merged

Fix wrong CASE WHEN values for bool references #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/expression_evaluator/reference_evaluator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,16 @@ inline static bool isTrue(ValueVector& vector, uint64_t pos) {

bool ReferenceExpressionEvaluator::selectInternal(SelectionVector& selVector) {
uint64_t numSelectedValues = 0;
auto selectedBuffer = resultVector->state->getSelVectorUnsafe().getMutableBuffer();
if (resultVector->state->getSelVector().isUnfiltered()) {
for (auto i = 0u; i < resultVector->state->getSelVector().getSelSize(); i++) {
auto selectedBuffer = selVector.getMutableBuffer();
auto& resultSelVector = resultVector->state->getSelVector();
if (resultSelVector.isUnfiltered()) {
for (auto i = 0u; i < resultSelVector.getSelSize(); i++) {
selectedBuffer[numSelectedValues] = i;
numSelectedValues += isTrue(*resultVector, i);
}
} else {
for (auto i = 0u; i < resultVector->state->getSelVector().getSelSize(); i++) {
auto pos = resultVector->state->getSelVector()[i];
for (auto i = 0u; i < resultSelVector.getSelSize(); i++) {
auto pos = resultSelVector[i];
selectedBuffer[numSelectedValues] = pos;
numSelectedValues += isTrue(*resultVector, pos);
}
Expand Down
6 changes: 6 additions & 0 deletions test/test_files/function/case.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ Farooq
Greg
Hubert Blaine Wolfeschlegelsteinhausenbergerdorff

-LOG CaseBooleanReferenceTest
-STATEMENT UNWIND [false, true] AS metric_0_value WITH *, CASE WHEN metric_0_value THEN "yes" ELSE "no" END AS label_value RETURN metric_0_value, label_value
---- 2
False|no
True|yes

-LOG CaseDoubleTest
-STATEMENT MATCH (a:person) WHERE a.ID < 6 RETURN CASE WHEN a.eyeSight > 4.9 THEN a.eyeSight ELSE 1.0 END + 2.0
---- 4
Expand Down
Loading